Responsive result summary for absolute Begineers

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing your first challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • This solution generates accessibility error reports due to non-semantic markup

  ---

  • So fix it by replacing the <div id="root"> with semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark elements ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  HEADINGS ⚠️:

  ---

  • And, This solution generates accessibility error reports due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  I hope you find it helpful ! 😄 Above all, the solution you submitted is great

  Happy coding!

  0
• 

  faizan•2,420

  @afaiz-spacePosted over 1 year ago

  hey @nikitabarnawal,

  • change color / 100.
  • why not use heading tags for heading.
  • verticle align icons and heading.

  0

  ---

  

  Nikita Barnwal•40

  @nikitabarnawalPosted over 1 year ago

  @afaiz-space Hey, thanks for the feedback. I will check into it and update the code. Thanks again

  0