Responsive Result Summary Component with Html and Css

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestions about your code that might interest you.

  • Images such as icons serve only for decoration purposes. You can use an empty alt attribute alt="" so that screen readers ignore that image and you can reduce the amount of noise for some users.

  • The font size is very small. Have you followed the styles in the style-guide.md?

  • To avoid causing a pause when reading with some screen readers, you should group "76 of 100" into a single paragraph with a span inside to make the number 76 larger, just as you have currently done with the punctuation in "72 / 100".

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .wrapper {
     margin: 4rem auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  lastiroko•130

  @lastirokoPosted over 1 year ago

  Looks quite good but you can give your body a

  display: grid;
      place-content: center;
      height: 100%;
  

  to place the whole content in the center(for desktop).

  You can also add a

  display: grid;
  place-content: center; 
  margin-inline: auto;
  

  to centralize the content in the scire circle. (edit as required for your code)

  0