Responsive result summary component

Community feedback

• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You can wrap up .attribution class within <footer> as a part of semantics.Wrapping the .attribution class within a <footer> element is a great way to improve the semantics and structure of your code. By using the appropriate HTML elements for their intended purpose, you enhance the accessibility and readability of your website.

  The footer section typically contains information about the author, credits, copyright notice, or links to related resources. In this case, the attribution information for the challenge and the coder would fit well within a footer element.

  Here's the updated code using a <footer> element:

  <footer>
  <div class="attribution">
  Challenge by
  <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">DvoraG</a>.
  </div>
  </footer>
  

  By using the <footer> element, you provide clearer semantics to both users and search engines, indicating that the content within it is part of the footer section of the webpage.

  Marked as helpful

  0

  ---

  

  DvoraG•100

  @DvoraGPosted over 1 year ago

  @Kamlesh0007 Thanks a lot for your advice and your nice review!

  0