Design comparison
SolutionDesign
Solution retrospective
Please rate and leave comments. I'd like to improve on this.
Community feedback
- @AGutierrezRPosted 11 months ago
Hello there @Khalifa-pendrops 👋. Good job on completing the challenge!
I have some suggestions about your code that might interest you.
General Structure and HTML:
- Wrap the primary content within the
<main>
tag instead of using it as a standalone component like a<div>
. - All the content should be contained within landmarks. Every page minimally needs a
<main>
element.
CSS and Styling:
- Implement CSS custom properties to define and utilize project colors more easily.
- Avoid using
px
forfont-size
, you could read this article to learn why. Letter spacing and line height must not be inpx
, userem
for all the font-related properties. You could transform thetext-[Npx]
in atext-[Nrem]
instead
I hope you find this helpful 😁. Most importantly, your submitted solution is fantastic!
Happy coding!
0@Khalifa-pendropsPosted 11 months ago@AGutierrezR thank you for this. Will implement and take note going forward. I appreciate it!
0 - Wrap the primary content within the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord