@Stroudy
Posted
Hello, Great solution, so close to the design! Few things I have noticed,
- Your heading elements are not in a sequentially-descending order
<h1><h2><h3>
top to bottom yours is<h1><h3><h2>
, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies. - Missing a
<meta>
description tag for SEO purposes - Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Line height is usually unitless instead of
line-height: 150%;
should useline-height: 1.5;
this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately. - Check out this article from a Frontend mentor dev about responsive-meaning.
- Having an aspect ratio on your images will increase performance to reduce layout shifts and improve CLS,
Love the fact your using responsive units like rem
and em
, Overall great solution and I look forward to seeing more from you! Happy Coding!
Marked as helpful
@hellcsaba
Posted
Hi Steven (@Stroudy ),
Thank you for your detailed comment and pointing out some weaknesses in my code. I'll update this project soon and also I'm going to pay attention in my future projects. During this project I read about BEM and I was thinking about introducing it. I'm sure that in my next project I'll use it. Also thanks for highlighting that the line-height is unitless and for the useful articles.
If you have time later, I'd be glad to hear from you in the future. Cheers.