Skip to content
Submitted 2 months ago

Responsive recipe-page using pure CSS and HTML

Csaba Hell•140
@hellcsaba
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Recipe page
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I learnt how to use ::marker pseudo-element for styling list items and :not, :last-child pseudo-classes. During the development I gained experience using tables and customizing their style. At the end it was inconvinient to meet the requirements of responsiveness for mobile view because of the image of the recipe. Probably in my next project I will work with mobile-first workflow.

What challenges did you encounter, and how did you overcome them?

At the end it was inconvinient to meet the requirements of responsiveness for mobile view. The reason for that is the recipe-image in mobile view fills up the entire space till the end of the top part of the screen. I set a 2.4rem padding on the article which was perfect for the desktop view. However, in mobile view it's a problem for the image. I don't think I did a nice solution for the mobile view but I solved it by adding a wrapper div for the image and set padding for every section.

What specific areas of your project would you like help with?

Is there a best practice for the recipe image's responsiveness? I mean mobile view full (top) screen and desktop view (with padding).

Community feedback

  • Steven Stroud•11,890
    @StroudyPosted 2 months ago

    Hello, Great solution, so close to the design! Few things I have noticed,

    • Your heading elements are not in a sequentially-descending order <h1><h2><h3>top to bottom yours is <h1><h3><h2>, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies.
    • Missing a <meta> description tag for SEO purposes
    • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
    • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
    • Line height is usually unitless instead of line-height: 150%; should use line-height: 1.5; this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately.
    • Check out this article from a Frontend mentor dev about responsive-meaning.
    • Having an aspect ratio on your images will increase performance to reduce layout shifts and improve CLS,

    Love the fact your using responsive units like rem and em, Overall great solution and I look forward to seeing more from you! Happy Coding!

    Marked as helpful
    2
    Csaba Hell•140
    @hellcsabaPosted 2 months ago

    Hi Steven (@Stroudy ),

    Thank you for your detailed comment and pointing out some weaknesses in my code. I'll update this project soon and also I'm going to pay attention in my future projects. During this project I read about BEM and I was thinking about introducing it. I'm sure that in my next project I'll use it. Also thanks for highlighting that the line-height is unitless and for the useful articles.

    If you have time later, I'd be glad to hear from you in the future. Cheers.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord