Design comparison
SolutionDesign
Solution retrospective
Hello everybody, this is my first challenge using jQuery Any suggestions on how to improve my skills is greatly appreciated!
Community feedback
- @BlackpachamamePosted 10 months ago
Greetings! you have done a great job š
š Some suggestions
- The image is part of the card, so you should not place it as a background, but as another element of the card
- To improve the semantics of your HTML, you can change your
<div class="attribution">
to a<footer class="attribution">
- Do not use
%
forwidth
orheight
. Better userem
,em
orpx
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord