Responsive Recipe Page using HTML, CSS, and Flexbox
Design comparison
Solution retrospective
I'm proud that I was able to create this project with my lack of knowledge in implementing frontend designs. I think I was able to more or less implement the design.
What challenges did you encounter, and how did you overcome them?I didn't know how to use pseudo-classes for designing the table. I also didn't know much about specific css knowledge, like for designing lists.
What specific areas of your project would you like help with?I don't have questions right now, but I would like constructive feedback for the code, if there was a way I could have implemented the design better and simpler.
Community feedback
- @MikDra1Posted 3 months ago
Your code is well-organized and functional, but there are areas for improvement:
-
DRY Principle: The @font-face declarations could be consolidated. Instead of repeating the font-family, font-style, and format, these can be combined where possible to reduce redundancy.
-
Font Smoothing: Add -moz-osx-font-smoothing: grayscale; for Firefox support alongside -webkit-font-smoothing.
-
Redundant CSS: The height: auto; for html, body is unnecessary since it's the default behavior. It can be removed for simplicity.
-
Color Variables: Consider using semantic variable names (e.g., --primary-color, --secondary-color) instead of color-based ones for better scalability.
-
Font Weight in recipe-title: Use a defined weight (e.g., font-weight: 400;) instead of 500 to match a loaded font weight.
-
Remove Duplicate Rules: The .instructions-section class is declared twice. This duplication should be removed.
-
Global Reset: Consider adding a box-sizing: inherit; rule in html for consistency when additional elements are added.
If this comment was useful please mark it as helpful 💗
Good job and keep going 😁😊😉
Marked as helpful2 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord