@thibault-deverge
Posted
Overall Feedback: First off, great work! You've created a design that is very close to the original, and it's clear you've put a lot of effort into making it as accurate as possible. Your attention to detail really shows, and you've done an excellent job. While it's almost pixel-perfect in many ways, there are a few minor inconsistencies that could be refined.
Visual Feedback:
- Typography: The font weight for the headings could be bolder, and the font family for the main
<h1>
heading is not quite the same as in the design. Fixing this will make your design even closer to the original. - Image Responsiveness: On mobile devices, the image should be full width. It currently looks a bit constrained, so ensuring it expands to the full width will improve the layout on smaller screens.
- Layout Shrinkage: The design feels a bit too "shrinked" on smaller screens. You might want to look into using
max-width
for better fluid responsiveness across different screen sizes.
Overall, your design is really solid and close to the original. Just a few tweaks can make it perfect!
Code Feedback:
-
External Styles: It’s a good practice to extract your CSS into a separate
.css
file. While keeping styles inline is fine for a small project, it's best to get into the habit of separating HTML and CSS as projects grow in complexity. -
Use of
id
vsclass
: Usingid
for styling works, but it’s generally better to useclass
attributes.class
allows for reusability and has lower specificity, making your CSS easier to maintain and more scalable. It also opens the door to utility classes (like in Tailwind CSS) and reusing the same styling across multiple elements. Also for the naming convention, here is a good one I personnaly use if it can be helpfull Link BEM Method Explained -
Semantic HTML: You could enhance your HTML structure by using more semantic elements. For example:
- Wrap the entire recipe inside a
<main>
tag. - Use
<section>
elements for distinct parts of the recipe, such as Ingredients, Instructions, and Nutrition. - Encapsulate the entire recipe inside an
<article>
tag to make it clear that it's a self-contained piece of content. - Consider using a
<table>
for the Nutrition section, as it’s tabular data.
These changes will improve accessibility (especially for screen readers) and help with SEO. Semantic HTML - Kevin Powell
- Wrap the entire recipe inside a
-
Relative Units: It's important to avoid using
px
for font sizes, padding, and margin, as it can hurt responsiveness. Using relative units likerem
andem
will make your design more adaptable to different screen sizes. Pixels should generally be reserved for fixed values likeborder-radius
or other small details that don’t need to scale. Kevin Powell - CSS em and rem explained Kevin Powell - Are you using the right CSS units
Conclusion: You’re really close to nailing this project, and it’s clear that you’re on the right path. There are a few improvements to consider, but overall, your work is excellent. Keep it up, and I’m excited to see what you do next!
Best of luck, and happy coding! 🚀
Marked as helpful