@DylandeBruijn
Posted
@JEWebDev
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
- Responsive
Things you could improve ✍️
- You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful
@JEWebDev
Posted
@DylandeBruijn
Thank you for your feedback, feels great to know what you liked about the solution and helps me know that i implemented it well.
I will make the changes to the body as you suggested.