Design comparison
SolutionDesign
Solution retrospective
What challenges did you encounter, and how did you overcome them?
list-style-position: outside;
What specific areas of your project would you like help with?If you have time, please provide feedback.
Community feedback
- @DylandeBruijnPosted 4 months ago
Hiya @trskldnt,
Congratulations on another great looking solution! Glad to see you are making a lot of progress. Things I like:
- Use of semantic elements.
- Clear and descriptive classes using BEM, very nice!
- Use of CSS custom properties.
- Knowledge of less known CSS elements like
::marker
and proper styling of these elements.
As always a bit of friendly constructive feedback:
- You have some overflow issues on the
.recipe-card__preparation
element. See the styling below:
.recipe-card__preparation { border-radius: 12px; padding: 28px; height: 180px; background: var(--snow); }
I suggest removing the fixed height and keeping it as
auto
.- In your table your could replace the
td
elements used as table headers withth
elements. Like so:
<th>Calories</th>
Everything else looks great! I would appreciate it if you could mark my feedback as helpful when you have the chance and if it helped you out.
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord