Responsive Recipe Page

Community feedback

• 

  T

  Chamu•13,340

  @ChamuMutezvaPosted 7 days ago

  Hi Abdulsamad

  Congratulations for taking the challenge, here is my opinion

  • the HTML and CSS should be in separate files.
  • the element in your code <heading class="title-section"> does not exist. I think you wanted to use the header element.
  • use semantic elements always. For example you have <p class="subheading">Preparation time</p> , if this is a heading element then use only elements that are meant to be heading elements (h1 - h6)
  • the max-width: 144rem; on the body element is not necessary. It is one element that should not have any changes to its width.
  • the site is not displaying the correct html page.

  Recommendation

  Please use the Learning path section and start from the beginning. It will guide you on many basic things including how to properly deploy your site on GitHub. This also gives you an opportunity to identify areas in your learning that needs cementing without being overwhelmed. The link for the Learning path is at the top of this page

  Marked as helpful

  0

  ---

  

  Abdulsamad•80

  @Abdul-adePosted 6 days ago

  @ChamuMutezva Thank you very much for this much needed feedback. All my shortcomings would be worked on, I think I rectified the display issue on my repo. Thanks once again for this feedback.

  0