Design comparison
Solution retrospective
Struggled with grid part. But completed it. Feedbacks are appreciated.
Community feedback
- @adonmez04Posted 9 months ago
Hi @RevadiSundaram. That's a good solution, keep coding. Here are some tips for you:
-
You don't need to use the
width
property for your container element. Usemax-width
ormax-inline-size
instead. You can use the declarationmax-width: 800px;
instead of thewidth: 800px;
in yourmain
element. This will make your container element responsive. You also will need to change thewidth: 300px;
declaration for the media at-rule tomax-width: 300px;
-
You can give your
img
elementmax-width: 100%;
anddisplay: block;
which will make your img elements responsive.
Note: Try to solve the same challenge at least twice, it will teach you something different each time.
I hope these will help you. Keep coding and have a nice day...
Marked as helpful0@RevadiSundaramPosted 9 months ago@adonmez04 Thank you for the feedback. Will be implementing it for next projects.
1 -
- @juanperez06Posted 9 months ago
Hey Revadi
Nice work! The only thing I would suggest you is to focus on website responsiveness. Your project isn't responsive. Try minimizing the browser window to see what I'm talking about. In smaller devices your project will be hard to read. This is not the best user experience (UX).
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord