Responsive Recipe Menu

Community feedback

• 

  P

  Justin Connell•720

  @justinconnellPosted 8 months ago

  Hi @rowanDeveloper,

  Great job submitting your solution! - I took a look at your code - it's pretty clean and well docuented - I like that you added comments on the decisions you made, this is really good, keep it up.

  Also your level of commenting is good - you only comment on what needs explination and don't state the obvious. One thing that can improve is to keep your comments consistent in terms of placing them on the line above the code line so that there's no need to scroll right - this will help the legibility of your code.

  Also you may be interested in applying some BEM to your projects going forward - you make good use of naming and I think BEM could be a good fit for you. You can check that out here.

  Last thing, I noticed you tagged the solution with sass/scss but I noticed the style was in CSS - are you using scss for other projects?

  I hope you find this feedback helpful!

  Keep up the good work and continue improving! J

  Marked as helpful

  1

  ---

  

  Rowan•210

  @rowanDeveloperPosted 8 months ago

  @justinconnell Thanks a lot for the comment! I really appreciate it! Plus, comments and advice are the best reward I can get.

  I really like commenting on my code, first to keep it organized and second because, while I am coding, I actually try and play with different approaches, just to see what is best and how I can improve. So comments are really important for that.

  I haven't heard about BEM. I'm curious about this approach and how it can help me improve my coding skills.

  Again: thanks a lot for the advice!

  1