Design comparison
Solution retrospective
I'm finally getting the hang of using CSS's ability to do variables, pseudo-selectors, and nested rules.
What challenges did you encounter, and how did you overcome them?I had some issues getting the image and article sections to visually look like the design file. This was my first mobile-first approach project.
What specific areas of your project would you like help with?Would love feedback on my CSS and how I could optimize it or clean it up.
Community feedback
- @efabrizio75Posted 3 months ago
Well done Jennifer! Congratulations on competing another challenge!
As you requested, I took a look at opportunities in your CSS and what came to mind was in the
table
element: have you considering using theth
tag so you don't need to resort to pseudo-selectors? Even though the table is oriented differently, "Calories", "Fat", "Protein", and "Carbohydrates" are still acting as headers.When I looked at the instruction steps, I noticed that maybe some left padding is needed. Likewise, I am curious about the
counter-reset
usage: I thought there was no need in this case, but in case you know more I'd very interested to learn :)I really liked your exploration and usage of the nested rules in CSS! It reminded me that I should do more of it :-P
Ah, the
hr
element appears a bit thicker than the design. It's not an easy element to style, but you could try by assigning an overall border of1px
to it, and then eliminate either the top or the bottom:hr { border: 1px solid var(--clr-stone-600); border-bottom: none; }
Again, awesome work and continue with more challenges!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord