Design comparison
Solution retrospective
- Really glad that I managed to make this website responsive on both mobile and desktop
- Learned how to style tables a little
Would probably use SASS CSS next time to simplify CSS code or something
What challenges did you encounter, and how did you overcome them?- Messy css
- Arrangement of layout
I watch a couple of youtube videos and use MDN docs for additional styles
What specific areas of your project would you like help with?- is my css a bit messy?
- how can I improve and write more efficient CSS
Community feedback
- @DylandeBruijnPosted 4 months ago
@DoneWithWork
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Responsive
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve ✍️
-
Add a bit of padding to your body element so the card has room to breath on smaller viewports.
-
Remove the
border-radius
of the image on smaller viewports so it's more in line with the design. -
Remove the wrapper
<div>
of the image, you can style the image directly if you want. -
You can write this
padding: 20px 20px 20px 20px;
aspadding: 20px;
it's shorthand for the same thing. -
You could remove the
<thead>
element as it's empty. -
Try setting the
font-family
on thebody
. Other elements will inherit thefont-family
from their parent due to the CSS cascade. If you want to have a differentfont-family
for the headings you can selecth1, h2, h3, h4, h5, h6
and give them thatfont-family
instead.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord