Responsive React.js QR Code Challenge

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • It's fantastic that you started with 300px; the solution dimensions (345 and 1440px) are merely to choose the resolution of the image that appears as preview. The minimal width recommended for any webpage without losing content or causing a horizontal scrollbar is 320px.

  • Use semantic elements such as <main> and <footer> to improve accessibility and organization of your page.

  • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute. The alt attribute should explain its purpose. e.g. QR code to frontendmentor.io

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  0
• 

  Abdulelah•540

  @Abdulelah-AbacarPosted almost 2 years ago

  Hi, Christina I hope that you had a great time while doing this challenge. I have some note on the code, At first it will be good if you take care about "block Element" width because by default they take the full width so when you set the width to be 100% it may cause problems later. And I hope that make sense for you ^_^

  Marked as helpful

  0