Responsive react app with flexbox & css grid

Community feedback

• 

  not-a-patch•200

  @notapatchPosted about 3 years ago

  In your Dashboard.js why did you decide to put the data in Javascript object literals:

  const dailyData = [{ current: 5, previous: 7 },
      { current: 1, previous: 2 },
      { current: 0, previous: 1 },
      { current: 1, previous: 1 },
      { current: 1, previous: 3 },
      { current: 0, previous: 1 },
      ];
  

  Rather than importing the data in from the JSON file?

  0

  ---

  

  TOLBA Rafik•280

  @DyiosPosted about 3 years ago

  @notapatch , Hi i used them for prototyping and after i finished i saw that if i use the JSON file most of the logic had to be changed so i kept them. I focused more on the design because i never used css grid and i liked the layout of the cards. For the logic part i didn't spend much time, after i submitted the solution i noticed some things that i forgot, i decided to move to other project to learn more of what i need. thank you for you'r comment.

  1