Responsive rating page with HTML, CSS and Javascript.
Design comparison
Solution retrospective
Just finished this! feedbacks are welcome.
Community feedback
- @visualdennissPosted over 1 year ago
Hey Victoria,
cool work again! I'd have few suggestions for further improvements:
-
Using width: 30vw; is not necessary, it'll only cause it to shrink too much when resizing, instead using something like width: 100%, max-width: 450px (in rem/em) is a better approach.
-
You have used height: 50vh; but in general try to avoid giving fixed heights or max-heights for text containing elements like you have for .container, even if it is in rem, because it can cause issues later on (with changing dynamic data, when the user changes font-sizes, or even browser rendering issues etc.). The container height should be determined by the height of its children elements.
-
Adding a cursor: pointer; to the all buttons would be good, indicating interactivity to the user (UX)
-
the paragraph text seems a little too cramped, increasing the line-height slightly would give them some breathing room and improve readability.
-
Font family seems to be missing for "You selected 3 out of 5"
Hope you find this feedback helpful!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord