Responsive Rating

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted over 1 year ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  The HTML for the ratings needs to be rewritten as it was done incorrectly ❌. button are for submitting a form, opening/closing mobile navs, etc…

  To ensure that the "rating buttons" are fully accessible 💯, they need to be built using a form ⚠️.

  1. Everything will be wrapped inside a fieldset which will have a legend that is visually hidden using CSS.
  2. Inside, there should be five input radios and each input should have a label attached to it to make the “ratings” accessible.
  3. The last thing you will want to include will be a button so users can submit their choice.

  More Info: 📚

  MDN: Form Element

  MDN: <input type="radio">

  MDN: Field Set Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 👾

  1

  ---

  

  ecaleb97•230

  @ecaleb97Posted over 1 year ago

  Hi, @vcarames thank you for you suggestion. I'll keep it in mind. 👍

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted over 1 year ago

  @ecaleb97

  You definitely need to make these changes before moving on the next challenge. If not, chances are you will continuously make the same mistakes.

  • To get the ‘rating’ give each rating the same name (ex. name=“rating” and then you would do the following const rating = form. rating.value

  • Once the top is implemented , for your JS, the eventListener should be on the form as a submit.

  More Info:📚

  Click vs. Submit EventListeners

  0