@PhoenixDev22
Posted
Hi Ibrahim Isiaka
Congratulation on completing your first frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:
- You should use
<main>
landmark to wrap the card. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
- In my opinion, the image is an important content. The alternate text should indicate where the Qr code navigate the user: like
QR code to frontend mentor
not describes the image. The alternate text should not be hyphenated, it should be human readable.
- Using percentages alone for widths is not really a good way, as you are losing control of the layout Consider using
max-width
to the card inrem
instead. You donβt need to use any media queries.
-
In order to center the card on the middle of the page , you can use the
flexbox
properties andmin-height: 100vh
for the<body>
add a little padding to the body that way it stops the card from hitting the edges of the browser .No need for using position absolute. -
Remember a css reset on every project. That will do things like set the images to display block and make all browsers display elements the same.
- Consider including a git ignore. Less important in this challenge but will become extremely important as you move onto larger projects with build steps
Overall, Excellent work! Hopefully this feedback helps.
Marked as helpful