Design comparison
Solution retrospective
Which areas of my code you think I can improve?
Community feedback
- @NehalSahu8055Posted over 1 year ago
Hello Coder 👋.
Congratulations on successfully completing the challenge! 🎉
Few suggestions regarding design.
-
As you are already using flex, just add
height:100vh
andalign-item:center
to themain
to properly center the card. -
Every site must have one h1 element describing the main content of the page.
-
So, Add a
level-one heading
instead of h3 to improve accessibility. -
<h1>Improve you frontend skills by building projects</h1>
and adjust the font-size. -
For
non-decorative images
give meaningful and descriptive alt likealt= "QR code to frontend mentor website"
. -
Use
responsive units(rem, em, %)
from next project. Explore respective use cases on google. -
Replace
width
withmax-width
to make your card more responsive.
link.
I hope you find this helpful.
Happy coding😄
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord