Responsive QR-Code Web Page

Community feedback

• 

  Gabriel•170

  @ctrl-brokencodePosted over 1 year ago

  Hello! Congrats on uploading this challenge. I hope you don't discourage now and I hope you continue coding and learning from your mistakes. You will go far! Here are some suggestions I've made for you. Make sure to pay attention!

  • Make sure to have a well indented code for better readability;
  • para-1 should be an heading element (instead of p, use h1);
  • Don't forget to delete p on .para-content p. This will apply to both the paragraph and heading;
  • Make the alt text of the image clearer. Say where the QR Code is taking you;
  • There's no need of having width and height in body. Delete the width and change height: 100vh to min-height: 100vh;
  • On the other hand, the component (main container) should have a max-width in rem, but not a height. Remember that the height in the component will automatically be determined by the content inside;
  • The component should have one padding value. This will centralize your image a bit;
  • Display, flex-direction, justify-content and align-items won't be necessary;
  • QR Code Image should have display: block and width or max-width: 100%. Your image should be centered now because of the width and padding.

  Then make some adjustments on the paragraph content, like margin and padding, and you're done! Overall, your code is simple and easy to read. Again, careful with indentations. I wish you the best of luck!

  Marked as helpful

  0

  ---

  

  Sagar Bisht•10

  @sgr-web-devPosted over 1 year ago

  @Gabriel-H502 I really appreciate your guidance

  1

  

  Harry05•50

  @harry05555Posted over 1 year ago

  @Gabriel-H502

  hi, i think para-1 have been 2h , because it's a card, but if that's in the new screen on pop-up and alone, ok h1. h1 can stand only one time in the screen.

  0
• 

  Harry05•50

  @harry05555Posted over 1 year ago

  The whole elements should be nested, like

  <div class="card"> <div class="qrcode-bg"> <img> </div> <div> h1orh2 p </div> </div>

  Semantics is wrong main point to the main content. You can put a div in your main yes

  0