There are some important changes needed here
Html
- Container should be a
main
element. This is called a landmark and worth reading about to make sure you understand their use - The image is the most important content in this component. It is nit decorative. That means it needs a proper alt description like "QR Code to FrontendMentor.io"
- You should never have text in divs or spans alone. They are meaningless elements used for layout. For text you should always be using meaningful elements like heading and paragraph in this challenge
CSS
- Look up how to center a component o n the screen. In this case, your body element should have min-height 100vh along with flex or grid properties to center the component on the screen. The component should not have huge margins to try and center it
- You don't need max height on the image. Standard practice is to make images display block and max-width 100%.
- The container should not have an explicit width. Instead, use max width, so it can shrink if it needs to (like it does on my small phone screen)
- Give the card a small bit of margin so it can't hit the screen edges. Alternatively, you could give the body a little padding
- Font size should never ever be in px! Use rem. Very important
- This challenge does not need a media query
Marked as helpful
@abandonedwaffle
Posted
@grace-snow Thank you. Your feedback is much appreciated. I will keep all this points in mind and try to improve on it.
@abandonedwaffle
Posted
@grace-snow Hey. Thanks Grace. I have made changes to my code according to your feedback. I will keep these points on my mind from next time.