@Hassiai
Posted
Replace <div id="outermost"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
Give the body a background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
There is no need to style .outer-div. To center .qrcode on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
To center .qrcode on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
To center .qrcode on the page using grid:
body{
min-height: 100vh;
display: grid;
place-items: center;
}
There is no need to give .qrcode a height value, give it the same padding value for all the sides and replace the width with max-width for a responsive content.
Give the img a max-width of 100% for a responsive image.
Give .qr-info a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful
@Aditya-768
Posted
@Hassiai I happy that you gave your valuable feedback. I am improving it. Thanks again.
