Skip to content
Submitted almost 2 years ago

Responsive Qr-code using HTML and CSS

Aditya-768•50
@Aditya-768
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I easily made the outline of this challenge. But I took so much time to give it proper height and width and making it responsive. What do you think about its responsiveness? What are the areas I can improve in it?

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted almost 2 years ago

    Replace <div id="outermost"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html

    Give the body a background-color. Use the colors that were given in the styleguide.md found in the zip folder you downloaded.

    There is no need to style .outer-div. To center .qrcode on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.

    To center .qrcode on the page using flexbox:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}

    To center .qrcode on the page using grid:
body{
min-height: 100vh;
display: grid;
place-items: center;
}

    There is no need to give .qrcode a height value, give it the same padding value for all the sides and replace the width with max-width for a responsive content.

    Give the img a max-width of 100% for a responsive image.

    Give .qr-info a margin value for all the sides, text-align: center and a font-size of 15px which is 0.9375rem, this will be the font-size of both p and h1.

    Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    0
    Aditya-768•50
    @Aditya-768Posted almost 2 years ago

    @Hassiai I happy that you gave your valuable feedback. I am improving it. Thanks again.

    1
  • Abdessamad•210
    @styrexxPosted almost 2 years ago

    Hello there 👋. You did a good job!

    There are a few changes you can make to make your solution better.

    • It is better to set the background-color to your <body>, not some <div>

    • To have a better responsive page you can use a flexbox to center the content no matter the viewport size. You can do the following:

    body {
	min-height: 100vh;
        display: flex;
	align-items: center;
	justify-content: center;
}
    • Fix the issues that have been reported.

    I hope you find this helpful.

    Marked as helpful
    0
    Aditya-768•50
    @Aditya-768Posted almost 2 years ago

    @kop-left Thanks for your valuable feedback. I will definitely work on it

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord