Responsive QR-CODE using HTML & CSS

Community feedback

• 

  Hexer•3,660

  @EmmanuelHexerPosted over 2 years ago

  Great work overall man. Keep it up

  Marked as helpful

  1

  ---

  

  Siddhi•90

  @siddhiePosted over 2 years ago

  @Phalcin Thank you for your feedback. Glad that you liked my work.

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Siddhi, great job!

  • try to use flexbox to the body for center the card. Read here -> flex guide
  • remove all margin from box because with flex they are superfluous.
  • after set heigth of body to 100vh because Flexbox aligns to the size of the parent container.
  • add main tag and wrap the card for Accessibility
  • Also instead of using px try to use relative units of measurement -> read here

  Overall you did well! Hope this help ;)

  Marked as helpful

  1

  ---

  

  Siddhi•90

  @siddhiePosted over 2 years ago

  @denielden Thank you for your valueable feedback. I'll work on it.

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @Siddhinandaniya You are welcome! And don't forget to mark my comment as helpful :) thanks

  Marked as helpful

  0

  

  Siddhi•90

  @siddhiePosted over 2 years ago

  @denielden Hi, I've updated my QR-Code project after you gave me your feedback. It helped a lot.

  Could you check once again my updated project?

  Thank you ;)

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @Siddhinandaniya done! Now it's much better, great job keep it up :)

  1