Responsive qr-code using CSS box model

Community feedback

• 

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  Hi @John-developer-18, how are you?

  Welcome to the front-end mentor community. You did a great job on this challenge, but I have a few tips I think you'll like:

  1- Document should have one main landmark, you could have put all the content inside the main tag click here

  I noticed that the content was not centered to fix this I made some changes to the code:

  body { display: flex; align-items: center; justify-content: center; min height: 100vh; }

  To make the code cleaner you could have just done:

  main img h1 p

  The rest is great! Hope it helps... 👍

  0

  ---

  

  Falana John•150

  @John-developer-18Posted about 2 years ago

  @AdrianoEscarabote Thanks I really appreciate the advice 🙏🙏

  0

  

  Adriano•38,120

  @AdrianoEscarabotePosted about 2 years ago

  @John-developer-18 no problem, keep coding!

  0