Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive qr-code using CSS box model

@John-developer-18

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Hi @John-developer-18, how are you?

Welcome to the front-end mentor community. You did a great job on this challenge, but I have a few tips I think you'll like:

1- Document should have one main landmark, you could have put all the content inside the main tag click here

I noticed that the content was not centered to fix this I made some changes to the code:

body { display: flex; align-items: center; justify-content: center; min height: 100vh; }

To make the code cleaner you could have just done:

main img h1 p

The rest is great! Hope it helps... 👍

0

@John-developer-18

Posted

@AdrianoEscarabote Thanks I really appreciate the advice 🙏🙏

0
Adriano 34,090

@AdrianoEscarabote

Posted

@John-developer-18 no problem, keep coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord