Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive qr-code scanner using flexbox

JoshBoluβ€’ 170

@JoshBolu

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • The color of the paragraph element is unreadable because it is too light compared to its background. For example, change the color to hsl(220deg, 15%, 55%).
  • Use more descriptive class names to improve readability of front-end code. You can learn BEM naming convention to improve your class names.
  • It's recommended that you always use the font provided by the challenge's style guide.To import a font, follow the steps below:

    • Go to the font's page on Google Fonts: https://fonts.google.com/specimen/Outfit.
    • A sidebar will appear with a code snippet that you can use to import the font.
    • Copy this code snippet and paste it into the <head> section of your HTML document.
    • Now you can use the "Outfit" font in your CSS by specifying font-family: 'Outfit', sans-serif;. I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding!

0
Abdul Khaliq πŸš€β€’ 72,660

@0xabdulkhaliq

Posted

Hello there πŸ‘‹. Congratulations on successfully completing the challenge! πŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

SUGGESTIONS :

  • Consider using semantic elements like main, header, footer instead of using plain div elements.
  • Semantic element ** are used to provide a more precise detail** of the structure of our webpage to the browser or screen readers
  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page
  • And for the CSS, The width: 100% property for .container is not necessary. because it's a block level element which will take the full width of the page by default.
  • So feel free to remove width: 100% style rule from .container this will help you to write efficient code and makes your code more reusable.

.

I hope you find this helpful πŸ˜„ Above all, the solution you submitted is great !

Happy coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord