Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive QR-Code Sample

@alexandria-lukachi-le

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback welcomed regarding any better styling practices =]

Community feedback

Venus 1,640

@VenusY

Posted

Great job on completing this challenge! The design almost perfectly matches the original design, so well done on the styling.

One small thing I would correct is your class names for your elements. Currently they're a little vague as they're only text-1 and text-2, which is fine on small projects like this that don't contain a lot of elements, however on larger projects, the vague class names might make it more difficult to know which elements you're referring to. I would suggest more semantic class names, such as "heading" and "description".

Marked as helpful

0

@alexandria-lukachi-le

Posted

Thank you, I understand how that could be confusing in a larger project. Thanks for the feedback, it's something I didn't even think about =] @VenusY

1
Venus 1,640

@VenusY

Posted

@alexandria-lukachi-le No worries! Good luck on your future projects. :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord