Responsive QRcode (React.js / SASS)

Community feedback

• 

  T

  Grace•31,230

  @grace-snowPosted over 2 years ago

  Definitely do all of the above...

  • except I recommend max width not width
  • and very important to change height 100vh to min-height as this is broken on mobile landscape atm
  • make container the main and attribution should be in a footer
  • remove that br - use css margin to create space between elements, not breaks (they have meaning and get read out my screenreaders)
  • Definitely need to rewrite that alt text. It needs to say exactly what it is. Eg "QR code to frontend-mentor.io"

  1

  ---

  

  Vinicius Batista•315

  @VbanetyPosted over 2 years ago

  @grace-snow thanks a lot for the advices, I'll fix it.

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Vinicius, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • to make it look as close to the design as possible set width: 20rem to container class
  • remove all margin from .container class because with flex they are superfluous
  • use min-height: 100vh instead height to body
  • instead of using px or % use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  1