Responsive QR-Code layout with some hovering and transition effects

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your project is looking fantastic!

  I'd like to suggest a way to make it even better:

  • Although it works, using position isn't always the most effective method for centering an element. It can cause bugs and may result in part of the content being cut off depending on the lenght of the card.

  Here's a highly efficient approach to position an element at the center of the page both vertically and horizontally:

  📌 Apply this CSS to the body (avoid using position or margins in order to work correctly):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  0

  ---

  

  Pavan.s•60

  @pavans5097Posted 6 months ago

  Thankyou for your wonderful feedback . It was really helpful for me . @danielmrz-dev

  1
• 

  SIDA•190

  @GSida015Posted 6 months ago

  COOL! you have good skills in css...

  BUT................

  You should follow the actual template,there's no need anything special like that. Yes you did what you told to but if in template there isn't providen specific image or detail that in this projects something should have hover effect you shouldn't do it...

  This website is all about getting experience! When you will get a job there will be providen a template... that you should follow!

  But in summary your solution is great!

  I hope I explained everything you needed! I would be glad if you mark this helpful!

  GOOD LUCK IN YOUR NEXT PROJECTS!!!

  Marked as helpful

  0

  ---

  

  Pavan.s•60

  @pavans5097Posted 6 months ago

  I am glad to hear your suggestion . I know this project is little off from the template but i will follow the template from next project @GSida015

  2

  

  Daniel 🛸•44,310

  @danielmrz-devPosted 6 months ago

  @GSida015 @pavans5097

  I have another perspective on this. Of course you should follow the template, but you can also customize your projects whenever you can, specially when you do it for practice.

  I always customize my projects when I have the chance. Not because I wanna make it more beautiful or anything like that, but when I wanna practice a new technology or some CSS skills that I'm trying to improve.

  Of course you can't do this on a job, but remember: You are practicing here.

  Marked as helpful

  1

  

  SIDA•190

  @GSida015Posted 6 months ago

  @danielmrz-dev I have very same perspective but I made it clear for him...because when he starts his professional career he knew that.I don't talk about in Frontend Mentor or any practice projects.

  1

  

  Pavan.s•60

  @pavans5097Posted 6 months ago

  That's great , i know i didn't follow template but i am learning these things , by customizing project i was able to study and apply filter , box-shadow , hover etc .For learning i think customizing would be good but it wouldn't be in case of working in a company @danielmrz-dev

  2

  

  SIDA•190

  @GSida015Posted 6 months ago

  @pavans5097 yea that was what I was trying to tell!

  1