Design comparison
Solution retrospective
Any feedback is much appreciated and very welcome👏
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @Bishalsnghd07!
Your solution looks excelent!
I have just one suggestion:
📌 In order to make your HTML code more semantic, use
<h1>
for the main title instead of a<div>
.Unlike what most people think, it's not just about the size and weight of the text.
-
The
<h1>
to<h6>
tags are used to define HTML headings. -
<h1>
defines the most important heading. -
<h6>
defines the least important heading. -
Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1@Bishalsnghd07Posted 10 months ago@danielmrz-dev Yeah, thank you very much, for your significant suggestion. Want to know one more thing from you Can you teach me little bit more about what is accessibility and where should I use it?
0 -
- @ZukizukPosted 10 months ago
Hello there, Congratulations on completing this project
Your solution looks nice!
I have few suggestions that I think might be of interest to you.
The heading elements are H1, H2, H3, H4, H5, and H6 with H1 being the highest (or most important) level and H6 the least. Only use one
<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on. The heading elements are H1, H2, H3, H4, H5, and H6 with H1 being the highest (or most important) level and H6 the least. In your code I didn't see any header tag which is a wrong thing to do so consider fixing that, every page have to gave at least one h1 tag.I hope this feedback is helpful
Other than that great job
Marked as helpful1@Bishalsnghd07Posted 10 months ago@Zukizuk Thank you very much for your valuable suggestion❤️
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord