@obocanegra-dev
Posted
Hello @Ur_dad! 👋
Congratulations on completing your first challenge! 🎉 You did a great job, and I'm really impressed with your work.
Here are some suggestions to further enhance your project:
First of all, I recommend moving the inline styles from your HTML and creating a separate CSS file. You can then link this CSS file in your HTML. This will help keep your code organized and make it easier to maintain and update your styles.
I highly recommend using semantic elements instead of relying heavily on <div>
elements. Semantic elements like <header>
, <nav>
, <main>
, and <footer>
provide meaning and structure to your HTML, improving both accessibility and SEO.
For the image, it would be even more descriptive to use "QR code to Frontend Mentor website" instead of just "QR code". This will provide clearer context and enhance the accessibility of your site.
Avoid using a fixed width for your container as it hampers responsiveness. Instead, consider using max-width
to allow your container to adjust fluidly to different screen sizes.
Set the min-height
of your container to 100vh
to ensure that it fills the entire viewport and is vertically centered. This will improve the overall appearance and user experience.
Remember to avoid using pixel units for font sizes. It's better to use relative units like rem
or em
. This ensures that your font sizes are responsive and adapt well to different devices and user preferences.
Keep up the fantastic work and continue challenging yourself! I'm confident that you'll achieve even greater results in your future projects. Best of luck! 💪🚀
If you have any questions or need further assistance, feel free to ask. Enjoy your coding journey! ✨😊
Warm regards, Oscar
Marked as helpful
@Ur-dad24
Posted
Hi @obocanegra-dev.
Thank you so much for your invaluable and insightful feedback. I will implement the suggestions to better my code.
Regards, Yobu.