Skip to content
Submitted about 2 years ago

Responsive QR-Code

Sammy048•20
@Sammy048
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What is the best way to understand how to make a page responsive? How to use grid in CSS?

Community feedback

  • Brian Wachira•130
    @ItsWachiraPosted about 2 years ago

    Great work.

    You can specify a percentage width on the parent content container to allow the paragraph and h1 tag to fit evenly.

    Marked as helpful
    0
  • Hyron•5,870
    @hyrongennikePosted about 2 years ago

    Hi @Sammy048,

    Below is a link to my solution. I'm not sure why you have a form tag wrapping all the other elements when there is no form?

    my solutions

    you can replace the form tag with a main tag. Let me know if you have any other questions.

    Marked as helpful
    0
    Sammy048•20
    @Sammy048Posted about 2 years ago

    Hi @hyrongennike,

    Checked your solution, and you did a great work. I did buy some few ideas from your solution but I quite didn't understand how your page was fully responsive and you didn't use the "@media screen" in your CSS. How did you go about that?

    0
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi Sammy048, congrats on completing this challenge!

    Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:

    Improve the card overall look adding the rounded borders to the component and also the image using border-radius: 15px

    The html structure is fine and works, but you can reduce at least 20% of your code cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    0
    Sammy048•20
    @Sammy048Posted about 2 years ago

    Hi @correlucas,

    Those are some good insights, I will for sure work to clean up my code. Thank you and looking forward to doing more interaction and solutions with you.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord