Responsive QR-Barcode page using media query

Community feedback

• 

  develoba•270

  @develobaPosted about 2 years ago

  👋 Hi @DoyeDesign, good job on this challenge!

  If you don't mind, I'll give you some recommendations about your code:

  • You closed your two containers elements (div) after closing the section element, which is the father element.
  • It is recommended to use semantic tags for HTML document. For example, the principal content should be in a main tag and the image could be wrapped in a figure element to give more semantical meaning.

  I hope this will help you! Happy coding! 😊

  Marked as helpful

  1

  ---

  

  Edoye•170

  @DoyeDesignsPosted about 2 years ago

  @develoba Thank you. it took me a while to see it though. I corrected it it and put all the contents in the main tag

  0
• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  Hey @DoyeDesigns, Congratulations on completing this challenge!

  Here is my feedback:

  • To center items at body of a page, just do this:

  body {
      min-height: 100vh;
      align-items: center;
      justify-content: center;
      display: flex;
  }
  

  • It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

  Keep doing a good job!

  Marked as helpful

  0

  ---

  

  Edoye•170

  @DoyeDesignsPosted about 2 years ago

  @Deolabest Thanks for your feedback. I tried it and it worked. cheers

  0