Responsive QR static page using html and css

Community feedback

• 

  Numan Iftikhar•160

  @numan-iftikharPosted about 2 years ago

  Hi, you did good work. Here are some tips:

  • Use main tag to wrap card content
  • Use flex-direction: column; to have footer at bottom
  • Brush up your flexbox if you need
  • Don't use media queries, these are just irrelevant
  • Use classes instead of ids
  • Decrease the height and width of your card
  • Use rem for font-size property

  Marked as helpful

  0

  ---

  

  Moises Aleman•10

  @AneuralPosted about 2 years ago

  @numan-iftikhar I still have problems with sorting the content properly, so I did it the best way I could, thanks for your recommendations, they are a great help for me.

  0
• 

  Cooger•270

  @Cooger17Posted about 2 years ago

  Hi @Aneural! You did well on this challenge.

  There some tips to improve your code:

  1- Use <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

  2- Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

  3- avoid some html errors and accessibility

  4- Use display flex on body to perfect align your main element and your footer.

  Feel free to look upon my solution on this challenge!

  Marked as helpful

  0

  ---

  

  Moises Aleman•10

  @AneuralPosted about 2 years ago

  @Cooger17 thanks for the recommendations, they are very helpful, I will try to correct my mistakes.

  0