Responsive QR scanner page

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Etinhandy! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉

  That's an interesting approach to figuring out the color code by yourself. Also, do you mean the style-guide.md instead of the stylesheet (CSS file)? All the color code is provided in the style-guide.md.

  Some suggestions.

  • The alternative text for the QR code should not contain the word "image". The semantic meaning of the img element will make the screenreaders pronounce it as an image.
  • I recommend improving the alternative text to "QR code to frontendmentor.io" to give the users more information about the QR code.
  • I recommend adding width and height attributes to each image element. This way, the browser knows how much space the image requires before it can be fully loaded. As a result, it would optimize CLS (Cumulative Layout Shift).

  Hope this helps. 🙂

  Marked as helpful

  0

  ---

  

  Etinhandy•30

  @EtinhandyPosted over 2 years ago

  @vanzasetia Thank you so much! I will take note of all your suggestions and implement them right away. You are awesome.

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @Etinhandy No problem! 😄

  0