Responsive QR Page

Community feedback

• 

  KapteynUniverse•2,170

  @KapteynUniversePosted 28 days ago

  Merhaba Batu, nice job.

  You used flex correctly on the body, the card is vertically centered but it doesn't look like it because body is as big as the content inside it at the moment. Adding min-height: 100vh; to the body will do better for the centering. Also you can remove the padding after this.

  Avoid using hard coded values, like width: 320px;, it will cause responsiveness issues, use max-width: 320px; instead, max-width: 20rem; would be even better. Em/rem units are better for responsiveness. I recommend you to check Kevin Powell's this video for better understanding.

  Using a modern css reset for every project will help you.

  For future projects; put the content in a main landmark for better accesibility

  Marked as helpful

  1

  ---

  

  P

  Batu Küçük•40

  @badukucukPosted 21 days ago

  I have updated my solution with your help. Thank you for your suggestions. I'm new to this, so your advice really helped me.

  1