Responsive QR Design

Community feedback

• 

  Mohamed Irfanullah M•20

  @MdIrfan-ulPosted 9 months ago

  the layout look good and responsive too. I liked your stylings that you made simpler .Your Code looks however you can use some meaningfull attributes for the non semantic tags like role ="heading" .

  0
• 

  keltiek•210

  @keltiekPosted 9 months ago

  Just starting out, but I believe it would be better to use flexbox and not absolute position. Also better to use h1 header.

  0
• 

  P

  Valeria Montoya•240

  @ValeriaMontoyaPosted 9 months ago

  Hi, here are some suggestions to improve the accessibility of your code:

  • Screen readers rely on alt text to describe images to users. Add an alt attribute to the <img> tag with a description of the QR code's purpose. For example: <img src="./images/image-qr-code.png" alt="QR code for Frontend Mentor" />
  • While <div> is generic, consider using more descriptive elements for specific content. In this case, replace the outer <div> with a <main> tag to indicate the main content area.
  • Headings (<h1> to <h6>) should be used in a logical order to structure the content hierarchy. Since there's only one heading currently, you can simply remove the <b> tag for bold styling (use CSS instead) and replace it with a <h1> tag.

  I hope my feedback is helpful! 🤓

  0