Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Responsive qr component using CSS Flexbox

@rsabbarwal

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What should i do to upgrade my skills?

Community feedback

theCavyDev 510

@okeke-ugochukwu

Posted

This looks great. The only way to get better is practice.

I noticed you explicitly defined the card width. I'd suggest you use more or implicit or relative units like %.

So instead of:

.main-content  {
   width: 315px 
}

You could do :

.main-content  {
   width: 90%
   max-width: 315px
}

This way, the card is responsive on small screens but does not exceed 315px. So it still looks good on bigger screens. (that's if you're taking the mobile-first approach)

But nice job still 🚀

Marked as helpful

0

@AbderrahmaneGuerinik

Posted

Nice work ! i suggest to :

.main-content  {
            width: min(350px, 90%);
         } 
  • Give a Class to every element in HTML ans use (BEM méthodologie for naming classes)[https://getbem.com/introduction/]

Enjoy coding

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord