@denielden
Posted
Hello Jorge, You have done a good work! π
Some little tips to improve your code:
- add
main
tag and wrap the card for improve the Accessibility - also you can use
article
tag instead of a simplediv
to the container card for improve the Accessibility - to make it look as close to the design as possible remove
heigth
to.card
class - remove all
margin
from.card
class - use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px or %
use relative units of measurement likerem
-> read here
Keep learning how to code with your amazing solutions to challenges.
Hope this help π and Happy coding!
Marked as helpful
@yorchAdalbert
Posted
@denielden Hi Deniel, I'm so happy for your feedback. I've learning a ton with this challenges and of course your tips. Thanks so much. Time to keep rocking...
@denielden
Posted
@yorchAdalbert You are welcome and keep it up :)