Responsive QR Component in Simple Way

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component.

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .card {
  margin: 1rem auto;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Uzma Khan•160

  @UzmakhPosted over 1 year ago

  @0xAbdulKhalid Thanks for your valuable feedback . I have done it in body as you suggested but I am in confusion Can we use display : grid; in body and flex in the card?

  0

  

  Uzma Khan•160

  @UzmakhPosted over 1 year ago

  .card { width: 380px; margin: 5rem auto;}

  Then may I remove the width also when removing the margin? what's the way in the grid to show card-space grid-template-column?

  0
• 

  Manjesh R V•320

  @manjeshrv592Posted over 1 year ago

  Responsive without media queries?

  You can use max-width on card instead of width. So it will occupy 100% if screen is below 380px.

  make sure you add padding to body or section, so your design won't stick to edges of the screen on smaller devices.

  Make sure you reduce overall width of the card and align it vertically at center using flexbox. So it will be more inline with the design file.

  Marked as helpful

  0