Responsive QR component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ARE NOT PROPERLY USED ⚠️:

  • This solution consists incorrect usage of <h3> so it can cause severe accessibility errors due to incorrect usage of level-three headings <h3>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's <h3> element which is this <h3>Improve your...</h3>, you can preferably use <h1> instead of <h3>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility

  ---

  • Example: <h1>Improve your front-end skills by building projects</h1>

  ---

  • If you have any questions or need further clarification, and feel free to reach out to me.

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Rohit Deshpande•870

  @rohitd99Posted over 1 year ago

  Hi YUVASRI06

  Congrats on completing the challenge.

  I'd like to suggest a few changes for improving your solution.

  1. You've used a h3 element for the title I'd suggest using h1 since each page must have a single h1 heading and all headings must be in order from h1 through h6.
  2. Instead of simply using a div to wrap your content , you can use semantic elements like main, section as per need.
  3. Add min-height : 100vh instead of just height: 100vh since that blocks the content from expanding if height is larger than 100vh , although on this challenge it is certainly not an issue but on challenges which expand more than the screen size it can be one.
  4. Also for your image you can have width: 100% instead of a fixed width.
  5. Use max-width on your container so that it can lower beyond a certain size.
  6. I also noticed a single p tag which might have been placed mistakenly so you might want to remove that too.

  Hope it helps

  Marked as helpful

  0