Responsive QR Code

Community feedback

• 

  Tobias•100

  @ToHXPosted almost 3 years ago

  Hi there,

  as I was handing in my solution shortly after yours I was taking a look at your code as the solution does look really good.

  I have some things I noticed as I am curious about your decisions :-)

  • You didn't use box-sizing: border-box;
  • You did give the container a vw and vh, but from what I learned width 100vw introduces overflow and instead of height 100vh you should use min height so the content can scroll when needed
  • You did use a <div> before the <main> where instead I would've guessed you use it after the main
  • You could give the card a max-width instead of the width

  Marked as helpful

  0

  ---

  

  Haikal Maulana•890

  @haikalmolPosted almost 3 years ago

  @ToHX thanks for your suggestion

  0
• 

  xZAYEDx•250

  @xZAYEDxPosted almost 3 years ago

  pixel perfect 👌

  0