responsive QR code with HTML & CSS using flexbox

Community feedback

• 

  Danijel Adrinek•420

  @DanijelAdrinekPosted 8 months ago

  hello moussahl, I really like your project and I love how similar to the design it turned out!

  however, I still managed to find some details that I think you could change, and that would help you become a better programmer, for example, you should make your body tag take up 100% of the user's screen so that the card can truly be centered like on the design. you can achieve that by giving your html and body tags a height of 100%, you should also remove all the margins on your body by adding a property of margin: 0; to your body

  you shouldnt be giving class names like container1, if you start numbering it, it can get confusing quickly, instead I propose a class name like text-container, because this container contains all of the text inside the card

  you didnt use any css variables, and css variables are a powerful tool, they are easy to use, but I wont be going into detail here, if you like, I have written a post about using solving this challenge, and some best-practices that will help you become a better web developer: https://dev.to/danijeladrinek/frontend-mentor-qr-code-challenge-4g9h

  I hope I helped you learn, and become a better web developer in this little time it took me to write this, and if you have any questions about anything I said, feel free to ask, have an amazing day, and happy coding! :)

  Marked as helpful

  1

  ---

  

  Moussa Haloui•10

  @moussahlPosted 8 months ago

  Dear @DanijelAdrinek Thank you about all your feedbacks i will take them on consideration and use them on my future projects, i learned from you a lot thank you again and have nice day :)

  PS : the link you dropped didn't work for me if you can resend it again.

  1
• 

  Danijel Adrinek•420

  @DanijelAdrinekPosted 8 months ago

  happy to hear I could help dude, and ofc, here it is:

  https://dev.to/danijeladrinek/frontend-mentor-qr-code-challenge-571d

  0