Martin Santillan• 70
@SantillanMartin
Posted
Cool, i will do it. I thought the <section> was semantic. So, the correct way to write semantic html is div instead of section ?. Thank you.
0
Design comparison
Community feedback
Adarsh Rai• 560
@AdarshRai0
Posted
Hi Martin, congratulations on your new challenge!
I took a look at your code and I have some tips for you. To avoid the HTML Issues Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections.
0
Martin Santillan• 70
@SantillanMartin
Posted
@AdarshRai0 Hi Adarsh, i really aprecciate your feedback. But to be clear, you are saying that i have to replace all section with h2-h6 elements ? Thanks.
1
Adarsh Rai• 560
@AdarshRai0
Posted
@SantillanMartin NO don't replace h2-h6 elements there the issue in the footer section
<footer class="attribution">
<section class="footer">
Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
Coded by 💕<a href="https://github.com/SantillanMartin" target="_blank">Santillan Martin</a>.
</section>
</footer>
To
<footer class="attribution">
<div class="footer">
Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
Coded by 💕<a href="https://github.com/SantillanMartin" target="_blank">Santillan Martin</a>.
</div>
</footer>
instead of placing section in footer replace it with div or put the attributes part in a div so the issue might go this will remove html issue
Marked as helpful
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord