@denielden
Posted
Hi mfs_code, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the card for improve the Accessibility - centering a
div
withabsolute
positioning is now deprecated, it uses modern css likeflexbox or grid
- use flexbox to the body to center the card. Read here -> best flex guide
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container - instead of using
px
use relative units of measurement likerem
-> read here - the image bg in the html is not necessary
Overall you did well 😁 Hope this help!
Marked as helpful
@mfscode
Posted
@denielden Thank you very much for the feedback :D
I will make another submission based on the inputs that you gave me, I am still struggling in flexbox but your link that you gave is very educational and easy to understand.
Very helpful input 👍
@denielden
Posted
@mfscode You are welcome! Keep it up :)