Responsive QR CODE Webpage using basic HTML and CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi mfs_code, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here
  • the image bg in the html is not necessary

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1

  ---

  

  mfs_code•20

  @mfscodePosted over 2 years ago

  @denielden Thank you very much for the feedback :D

  I will make another submission based on the inputs that you gave me, I am still struggling in flexbox but your link that you gave is very educational and easy to understand.

  Very helpful input 👍

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  @mfscode You are welcome! Keep it up :)

  1
• 

  Alazar Getachew•260

  @AlazarG19Posted over 2 years ago

  Nice solution there is actually no problem with it but you dont need to add the background image. they but that in the design just to show u what it will look like out side the browser .you can correct your current solution by increasing the scale of the whole body or your main container

  1

  ---

  

  mfs_code•20

  @mfscodePosted over 2 years ago

  @AlazarG19 Thanks for the feedback! I will submit another solution in which i dont add the background

  0