Responsive QR code Using HTML and CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

  ---

  • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
      min-height: 100vh;
      display: grid;
      place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  .main {
    margin-top: 10vh;
    margin-bottom: 30px;
    margin-left: auto;
    margin-right: auto;;
  }
  

  ---

  ---

  • Now your component has been properly centered

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Sumith Wickramasinghe•40

  @sumithkckPosted over 1 year ago

  Thank you so much for the advice and it was a great help

  0
• 

  Bader Idris•2,880

  @Bader-IdrisPosted over 1 year ago

  You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

  .container {
    display: absolute;
    top:50%;
    left: 50%;
    transform: translate(-50%, -50%);
  }
  

  the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

  Marked as helpful

  0

  ---

  

  Sumith Wickramasinghe•40

  @sumithkckPosted over 1 year ago

  Thank you soo much

  0
• 

  Cesar D.•400

  @ThatDevDiazPosted over 1 year ago

  Hey!

  Try using height: 100VH in your header to set the viewport high to 100%. Then you can use flexbox on the body to center the middle using justify-content: center; and align-items: center; . This will revolve your issue with the qr code not being centered.

  Also, try using font-weight to change the bold on the text so it better matches the original design. Pretty close though

  Marked as helpful

  0

  ---

  

  Sumith Wickramasinghe•40

  @sumithkckPosted over 1 year ago

  Thank you @ThatDevDiaz

  0