Responsive QR code using HTML and CSS.

Community feedback

• 

  Davi Martins Freire•160

  @davimartins017Posted 4 months ago

  you put a "display: flex;" in the body of the html, that's why your footer was next to the qrcode, not below. What might help is to divide it better, so you can work with each line separately and using id and class for that

  Marked as helpful

  0

  ---

  

  Chidinma•10

  @ChidiinmaPosted 4 months ago

  Thank you for this. Ibwas wonderung why. @davimartins017

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted 4 months ago

  Hi Chidinma

  Congratulations for taking your first challenge, here is my opinion after going through your project

  • make use of semantic elements where to improve the accessibility of your project. These are elements designed to serve a certain purpose and can be read assistive technology users. In this challenge I would expect the elements such as main and maybe footer as shown below

   <main class="code">
      <img src="./images/image-qr-code.png" alt="">
      <h2>Improve your front-end skills by building projects</h2>
      <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    </main>
    <footer class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
      Coded by <a href="https://github.com/Chidiinma">Chidinma</a>.
    </footer>
  

  The main element - provides the primary content of the site. You can read more here layout landmark elements

  • The image in this case is carrying a message , hence the alt value should be a message not an empty string

  • Format your code - the large white space between your content is not necessary

  • there is need to have a reset stylesheet , that ensures that your content is styled correctly between browser.

  • in your body style , you have height: 100vh; , change it to min-height: 100vh;, that is important as that allows content to scroll if it does not fit the screen. Still with the body, add flex-direction: column; so that the content flows top to bottom as per design. Apply some padding as well, to allow some space on mobile devices between the body an the content

  0