@AmrAbdelgwaad
Posted
Hey Joseph, Congratulations on completing your first project 🎉
I like how you used the <main> tag in your first project keep using them however, there are a few things to take into consideration:
-
You have an extra closing tag in the HTML line 28, you should take care of these as they will cause you huge problems in larger projects.
-
<h2 class="card-title"> Improve your front-end skills by building projects </h2>
this should be <h1> Learn more -
It will be really useful if you use a modern CSS reset like this one.
-
Font sizes should be in ems or rems, not px.
-
It's better for performance to use the fonts in <link> in the head tag and don't use import.
-
I am wondering why you are using multiple CSS properties to define border-radius it's widely supported see this.
-
We use margins to add spaces between elements think of flex and grid as a bigger thing to define a layout
I hope I am helpful and happy coding 😁
Marked as helpful
@ChewingOnCode
Posted
@AmrAbdelgwaad
Thanks for the help in the CSS Reset I've been using Meyers for awhile. I can appreciate the modern one. I'll look into that. I should have specified my border-radius as a root element instead. Also i should have specified my font-size in ems instead of a hard set pixel. I will strive to do this in future solutions.