Responsive QR Code using HTML and CSS

Community feedback

• 

  Amr mohamed•370

  @AmrAbdelgwaadPosted about 1 year ago

  Hey Joseph, Congratulations on completing your first project 🎉

  I like how you used the <main> tag in your first project keep using them however, there are a few things to take into consideration:

  • You have an extra closing tag in the HTML line 28, you should take care of these as they will cause you huge problems in larger projects.

  • <h2 class="card-title"> Improve your front-end skills by building projects </h2> this should be <h1> Learn more

  • It will be really useful if you use a modern CSS reset like this one.

  • Font sizes should be in ems or rems, not px.

  • It's better for performance to use the fonts in <link> in the head tag and don't use import.

  • I am wondering why you are using multiple CSS properties to define border-radius it's widely supported see this.

  • We use margins to add spaces between elements think of flex and grid as a bigger thing to define a layout

  I hope I am helpful and happy coding 😁

  Marked as helpful

  1

  ---

  

  Joseph Chu•50

  @ChewingOnCodePosted about 1 year ago

  @AmrAbdelgwaad

  Thanks for the help in the CSS Reset I've been using Meyers for awhile. I can appreciate the modern one. I'll look into that. I should have specified my border-radius as a root element instead. Also i should have specified my font-size in ems instead of a hard set pixel. I will strive to do this in future solutions.

  0
• 

  Ewa•190

  @zalewskaewa7Posted about 1 year ago

  Hello, Your solution is very good.

  In the future try also flexbox. Grid and scss is more complicated. Here is very good site to learn flexbox: https://css-tricks.com/snippets/css/a-guide-to-flexbox/

  In file style-guide.md you can see whitch colors to use and another informarions about project.

  Color for <p> .card-info change for Grayish blue.

  Keep it up and don't give up!

  Marked as helpful

  1

  ---

  

  Joseph Chu•50

  @ChewingOnCodePosted about 1 year ago

  @zalewskaewa7

  Thanks for the comment. I will take it to heart. Honestly flex-box is a huge weak point of mine because it's not that i don't understand the box model and how to move things around, i just get "turned around" ha ha. So I really appreciate you providing me a link to CSS tricks where i can better hone that knowledge for future use. I cannot believe i goofed on the colors after i specifically set them in the root. Well lesson learned there ha ha. I'll have to pay more attention next time! I look forward to your further critiques in the future.

  0