Responsive QR code

Community feedback

• 

  Francisco Carrillo•5,540

  @frank-itachiPosted almost 2 years ago

  Hello there 👋. You did a good job!

  I have some suggestions about your code that might interest you.

  CSS 🎨:

  • You can use grid or flexbox to center the content no matter the viewport size. Using Grid:

  body {
  	min-height: 100vh;
          display: grid;
  	place-content : center;
  }
  

  FlexBox

  body {
  	min-height: 100vh;
          display: flex;
  	align-items: center;
  	justify-content: center;
  }
  

  • Avoid using absolute length units px, especially for font-size and width properties, because they are not relative to anything else so that means they will always be the same size. Instead, you can use relative lengths like em or rem. The benefit of that last one is element which has that unit will scale relatively to everything else within the page, e.g., the parent container. You can dig up about it here.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy <coding /> 😎!

  0

  ---

  

  NafisMahmudAyon•10

  @NafisMahmudAyonPosted almost 2 years ago

  @frank-itachi Thanks For Suggestion. I already update my code.

  0